kakiuwang-ui commented on PR #25294: URL: https://github.com/apache/datafusion/pull/25294#issuecomment-5956492798
Thanks for the ping — fixed and rebased onto main (e69e4fb). The CI failure was a silent conflict rather than anything feature-related: `references_any_column` uses `TreeNodeRecursion`, which my branch's base still imported in `push_down_filter.rs`. On main that name was later dropped from the `datafusion_common::tree_node` import list, and since my diff never touched that line the merge took main's version — so the merged tree lost the import and failed with five `E0433: cannot find type `TreeNodeRecursion` in this scope`. That is also why the four failures were MSRV / wasm / macOS test / linux build (every job that actually compiles the crate) while fmt, semver and the doc jobs passed. Rebasing reproduced it locally; the import is restored in the commit that introduces the function, so each commit still builds on its own. Green locally on top of `c922f88`: - `cargo test -p datafusion-optimizer` — 923 + 26 + 5 passed, 0 failed - `cargo fmt -p datafusion-optimizer -- --check` — clean - `cargo clippy -p datafusion-optimizer --all-targets -- -D warnings` — clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
