mkleen commented on PR #25951: URL: https://github.com/apache/datafusion/pull/25951#issuecomment-5961012390
> Thanks @mkleen. > > The `is_supported_type` reminded me that we don't do the same thing for lists, maps, ... So approx_distinct does not work for (e.g.) floats but works for list of floats. I think it's something we should look at in a follow up. Thanks for the review @nuno-faria I agree, the container types such as lists, maps need another iteration. Technically the only unsupported types for `approx_distinct` are Float16, Float32 and Float64. DuckDB supports them. So maybe it's worth thinking to support them in datafusion as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
