jackylee-ch opened a new pull request, #25997:
URL: https://github.com/apache/datafusion/pull/25997
## Which issue does this PR close?
- N/A
## Rationale for this change
The `bit_and`/`bit_or`/`bit_xor` expr helpers build their rustdoc in the
`make_bitwise_udaf_expr_and_func!` macro by `concat!`-ing `"Returns the
bitwise"`, `stringify!($OPR_TYPE)` and `"of a group of values"` with no
separators. Since `stringify!(BitwiseOperationType::And)` is
`BitwiseOperationType :: And`, docs.rs renders `Returns the
bitwiseBitwiseOperationType :: Andof a group of values`.
## What changes are included in this PR?
The macro now takes a readable operation name (`"AND"`/`"OR"`/`"XOR"`),
producing `Returns the bitwise AND of a group of values`.
## What is the testing strategy for this PR?
`cargo doc -p datafusion-functions-aggregate`: the three expr fns now render
`Returns the bitwise {AND,OR,XOR} of a group of values`.
## Are there any user-facing changes?
Corrected rustdoc for the `bit_and`/`bit_or`/`bit_xor` expression functions.
No behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
