sunchao commented on PR #5835: URL: https://github.com/apache/datafusion-comet/pull/5835#issuecomment-5972141317
[#6548](https://github.com/apache/datafusion-comet/pull/6548) now implements Spark-compatible native `hash` and `xxhash64` for wide decimals, including nested decimals. Once that lands, it should supersede the decimal dispatcher path proposed here. Could we narrow this PR to non-foldable `sha2(payload, numBits)` after #6548 lands? That functionality remains useful and is outside #6548’s scope. The decimal routing tests and documentation would then need to expect native execution. #6548 is still a draft, so this depends on its validation and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
