viirya commented on code in PR #553:
URL: https://github.com/apache/datafusion-comet/pull/553#discussion_r1735413661
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2845,10 +2845,13 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
}
}
- // TODO: Support SortMergeJoin with join condition after new
DataFusion release
- if (join.condition.isDefined) {
- withInfo(op, "Sort merge join with a join condition is not
supported")
- return None
+ val condition = join.condition.map { cond =>
+ val condProto = exprToProto(cond, join.left.output ++
join.right.output)
+ if (condProto.isEmpty) {
+ withInfo(join, cond)
+ return None
+ }
+ condProto.get
Review Comment:
```scala
if (condProto.isEmpty) {
withInfo(join, cond)
return None
}
```
If it is `None`, it will return `None` earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
