dwsmith1983 commented on PR #4315: URL: https://github.com/apache/datafusion-comet/pull/4315#issuecomment-5976390625
#3183 was closed by #5037. `encode` now goes through the codegen dispatcher on every profile (3.x via #5037, 4.x via the `StaticInvoke` catch-all from #5692), so it matches Spark on malformed UTF-8 too, which the cast lowering here doesn't. If the native cast is still worth it as a speedup, it needs a rebase and numbers against the dispatcher; otherwise I think this can close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
