sunchao commented on code in PR #6587:
URL: https://github.com/apache/datafusion-comet/pull/6587#discussion_r4176902435
##########
.github/workflows/pr_build_linux.yml:
##########
@@ -469,6 +469,7 @@ jobs:
org.apache.comet.CometIcebergEncryptionSuite
org.apache.comet.CometIcebergRewriteActionSuite
org.apache.comet.CometIcebergWriteActionSuite
+ org.apache.spark.sql.comet.IcebergTransactionalCommitExecSuite
Review Comment:
[P2] Register `IcebergTransactionalCommitExecSuite` in
`.github/workflows/pr_build_macos.yml` too. The mandatory `Check missing
suites` preflight requires every suite in both workflows. Adding this suite
only to Linux makes `python3 dev/ci/check-suites.py` exit 255, blocking
downstream build/test jobs on every CI run. Adding the matching macOS entry
restores the expected successful preflight.
Evidence: At the reviewed head, `python3 dev/ci/check-suites.py` exits 255
with `Suite not found in workflow .github/workflows/pr_build_macos.yml:
org.apache.spark.sql.comet.IcebergTransactionalCommitExecSuite`.
`.github/workflows/ci.yml:191` invokes this check in preflight. Repeating the
check with only the missing macOS entry supplied through a disposable in-memory
fixture passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
