zhuqi-lucas commented on PR #23599: URL: https://github.com/apache/datafusion/pull/23599#issuecomment-5981218856
> @zhuqi-lucas, > > Thanks for working on this. Supporting `FilterExec` with embedded projections is a nice improvement, and the regression test covers the plan shape well. > > I found one correctness issue that should be addressed before merging. The rewrite currently drops `FilterExec::fetch`, which can change query results. Thank you @kosiew for review, addressed review comments and added more tests now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
