andygrove commented on issue #5586: URL: https://github.com/apache/datafusion-comet/issues/5586#issuecomment-5981492343
Closing this as not planned. Since it was filed, #5766 made the codegen dispatcher decline structs with repeated field names, so mixing `CodegenDispatchFallback` into `CometCreateNamedStruct` would no longer route these through the dispatcher. Main now declines duplicate-name structs wherever they would reach Java Arrow, and the enclosing operator falls back to Spark. Running them in Comet would need the Arrow boundary changes from #5603, which we decided not to take on (see the closing comment there). The cases that still fail are tracked in #6251, #6591 and #6592. Thanks @RRXXZZYY for picking this up and for all the work in #5603. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
