unikdahal commented on PR #5318: URL: https://github.com/apache/datafusion-comet/pull/5318#issuecomment-5982402001
Thanks @andygrove! Addressed all three comments: - **Cardinality memory:** I’d prefer to keep the `RoaringTreemap` switch out of this PR, since getting the reservation sizing and duplicate-vs-OOM error ordering right deserves a focused change. Opened #6608 for that, and added a note about the memory cost to the compatibility page. - **Spark 4.1+:** Opened #6606 to track native `MergeRowsExec` support on 4.1+ with the `MergeSummary` contract. The config docs now clarify that the flag only takes effect on Spark 3.5 and 4.0, with links to the follow-up issue. I also updated the compatibility page and fixed the `CometExecRule` comment. - **Tests:** Removed the redundant `COMET_ENABLED=true` entries. The explicit `false` baselines are still retained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
