viirya commented on code in PR #881:
URL: https://github.com/apache/datafusion-comet/pull/881#discussion_r1735574197
##########
spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala:
##########
@@ -75,9 +75,11 @@ abstract class CometTestBase
conf.set(MEMORY_OFFHEAP_SIZE.key, "2g")
conf.set(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key, "1g")
conf.set(SQLConf.ADAPTIVE_AUTO_BROADCASTJOIN_THRESHOLD.key, "1g")
+ // TODO we should no longer be disabling COALESCE_PARTITIONS_ENABLED
conf.set(SQLConf.COALESCE_PARTITIONS_ENABLED.key, "false")
Review Comment:
I removed it in
https://github.com/apache/datafusion-comet/pull/553/files#r1730694991, in order
to trigger a test case failed in current code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
