sunchao commented on PR #5505: URL: https://github.com/apache/datafusion-comet/pull/5505#issuecomment-5982551991
Confirmed against current main `ac9ae94d057013095fdf1b70e2d4bc5b24a58d90`: `releasePlan` stops `BatchProducer` and drops its stream before `update_metrics`, then drops the execution context and waits for its plan reservations to be released. The remaining-reservation timeout is already logged at `warn!`. This preserves the RAII pool-registration cleanup as well. That covers this PR's cancellation/metrics ordering problem more completely than its old 100 ms cancellation-only wait, as noted in #6261. There is no remaining implementation change to carry forward from this branch, so rebasing it would duplicate the stronger upstream fix. Leaving the PR open for the author's closure decision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
