sunchao commented on PR #5420: URL: https://github.com/apache/datafusion-comet/pull/5420#issuecomment-5982688210
Rebased onto main and addressed the remaining AVG review requests in `f99c3c8406fbb8b882734c34a353defbda342676`: the cancelling shuffle fixture row, the grouped maximum-precision ObjectHash AVG fallback, and the decimal division/final-range issue from https://github.com/apache/datafusion-comet/pull/5420#issuecomment-5876423243. Decimal division retains its i128 fast path and widens only an overflowing scaled numerator. A valid large average now survives scaling; a truly out-of-range result raises `NUMERIC_VALUE_OUT_OF_RANGE` in ANSI mode. Added native scalar/grouped regressions and Spark comparisons for both examples, plus the explicit ObjectHash result. Native core/test compilation, full Spark 4.1 reactor test compilation, Rust formatting, Spotless and whitespace checks pass. Runtime tests for the rebased head are pending in CI; all Spark profile and Spark 4.1 SQL labels remain enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
