sunchao commented on PR #5457: URL: https://github.com/apache/datafusion-comet/pull/5457#issuecomment-5982966325
Fixed the current-head strict Scala CI failure: removed the unused fallback helper and unused default argument, and made both benchmark Long conversions explicit. The strict local compile also caught the benchmark route label being discarded by Spark 3.5's Unit-returning withSQLConf; the label is now retained explicitly. The full Spark 3.5 reactor production/test compile with strict-warnings, Spotless and Scalastyle now passes. These changes affect tests and the benchmark only; the previously verified native/runtime implementation is unchanged. Hosted checks are pending for this follow-up commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
