rgbuilds commented on code in PR #26031: URL: https://github.com/apache/datafusion/pull/26031#discussion_r4178915231
########## datafusion/sqllogictest/test_files/topk_dynamic_filter_remap.slt: ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +statement ok Review Comment: The end-to-end SLT provides strong coverage for #26029. Since remap_children is also shared by HashJoin and projection/scan pushdown, would it be valuable to add a focused unit test that registers both a parent expression and one of its descendants, while also checking that an unmatched parent still allows descendant remapping? Non-blocking—the reported wrong-result path is already covered by the SLT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
