kosiew commented on code in PR #25334:
URL: https://github.com/apache/datafusion/pull/25334#discussion_r4181018207
##########
datafusion/proto-common/src/to_proto/mod.rs:
##########
@@ -292,6 +293,7 @@ impl TryFrom<&DFSchema> for protobuf::DfSchema {
field: Some(field.as_ref().try_into()?),
qualifier: qualifier.map(|r| protobuf::ColumnRelation {
Review Comment:
Could you add a DFSchema protobuf round-trip test with a dotted qualifier,
at least `TableReference::partial("my.schema", "table")` and ideally a full
reference too? The current tests cover `Column -> ColumnRelation`, but this
DFSchema writer is also changing and would benefit from direct regression
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
