SubhamSinghal commented on code in PR #25968:
URL: https://github.com/apache/datafusion/pull/25968#discussion_r4183167738
##########
datafusion/physical-plan/src/topk/mod.rs:
##########
@@ -2140,8 +2213,8 @@ impl PartitionedTopKRank {
return Ok(());
}
- // 1. Evaluate + encode partition columns into the reusable
- // scratch (cleared then appended).
+ // 1. Evaluate the partition and ORDER BY columns and encode each once
Review Comment:
Addressed in 2901db21221f6bdc87a8bc80d565902f730ec186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
