andygrove opened a new pull request, #6681: URL: https://github.com/apache/datafusion-comet/pull/6681
## Which issue does this PR close? No issue. #6659 reported this difference, which the user guide already lists as an accepted divergence, so it was closed. This corrects the Iceberg version the guide gives for it. ## Rationale for this change The user guide's accepted divergences say that manifest `value_counts` / `null_value_counts` for a float or double field under a nullable struct differ from iceberg-java's on Iceberg 1.10+. The difference starts in Iceberg 1.9.0. From that release `ParquetUtil.footerMetrics` delegates to `ParquetMetrics`, whose `metricsFromFieldMetrics` takes a field's value, null and NaN counts from the writer's `FieldMetrics` whenever one exists. In 1.8, `footerMetrics` took value and null counts from the footer. ## What changes are included in this PR? The version in that entry of `iceberg-writes.md` changes from 1.10+ to 1.9+. ## How are these changes tested? Docs only. Checked against the Iceberg sources at the release tags: `ParquetMetrics.java` exists from `apache-iceberg-1.9.0` on, `ParquetUtil.footerMetrics` delegates to it in 1.9.1 and 1.10.0, and in 1.8.1 it reads value and null counts from the footer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
