neilconway commented on PR #26039: URL: https://github.com/apache/datafusion/pull/26039#issuecomment-5999011002
On the other comments @comphead: * I agree that multi-byte benchmarks would be useful, although the same could be said of a lot of the string UDFs :) I'll defer that for now. * Personally I think leaving `inline_view` as a separate function makes the implementation more readable, so I'm inclined to leave that as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
