sam-1112 commented on PR #5957: URL: https://github.com/apache/datafusion-comet/pull/5957#issuecomment-5999211715
@andygrove Thanks for the detailed review and validation. I moved the three special cases into operator-level `sparkFallback` overrides. Local TopK returns the restored child, and both scans preserve their live DPP filters and the original logical link. The rule now calls `sparkFallback` uniformly, and I updated the documentation and added a direct Local TopK fallback test. The full `RevertNativeForTransitionHeavyStagesSuite` and the Iceberg DPP revert test pass on Spark 3.5 and 4.1: 38 tests on each profile. The 3.5 run also used strict Scala warnings. I opened #6687 to track the cached result-stage output-format issue separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
