richacode007-byte commented on code in PR #1783:
URL:
https://github.com/apache/datafusion-python/pull/1783#discussion_r4186425230
##########
python/datafusion/functions/__init__.py:
##########
@@ -5920,14 +5935,16 @@ def count(
if expressions is None:
args = [Expr.literal(1).expr]
elif isinstance(expressions, list):
- args = [arg.expr for arg in expressions]
+ args = [_to_raw_expr(arg) for arg in expressions]
else:
- args = [expressions.expr]
+ args = [_to_raw_expr(expressions)]
Review Comment:
Went with your first option: count("*") now means count(), like SQL, and
there's a test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
