sam-1112 commented on PR #6441: URL: https://github.com/apache/datafusion-comet/pull/6441#issuecomment-6000582385
@sunchao Thanks for catching the remaining `ResolvingFileIO` case. Fixed in `d638bfe`: we now resolve the actual delegate for the data location before reading Hadoop configuration. An `S3FileIO` delegate therefore ignores the wrapper’s Hadoop options, while a `HadoopFileIO` delegate retains its effective configuration. Delegate resolution failures trigger plan-time fallback. I also added a regression covering both `s3://` and `s3a://`, verifying that the wrapper’s endpoint and encryption settings are not forwarded to the native plan. Could you take another review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
