sam-1112 commented on PR #5956: URL: https://github.com/apache/datafusion-comet/pull/5956#issuecomment-6006860200
Thanks, @andygrove . Extreme UTC/NTZ coarse truncation now uses integer calendar arithmetic, so `Long.MaxValue` truncated to YEAR correctly returns `+294247-01-01`, while results outside the i64 range raise an error. The SQL regression now tests `date_trunc` directly with `expect_native(date_trunc)` and compares its results with Spark, keeping the NULL validity checks. Rust coverage includes adjacent maximum values and negative extremes; Rust and targeted Spark 3.5/4.1 tests pass, and forcing the extreme result to epoch zero makes the new SQL regression fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
