gabotechs commented on code in PR #25337: URL: https://github.com/apache/datafusion/pull/25337#discussion_r4193438231
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -190,7 +190,7 @@ SELECT c1, approx_percentile_cont(0.95, -1000) WITHIN GROUP (ORDER BY c3) AS c3_ statement error Function 'approx_percentile_cont' failed to match any signature SELECT approx_percentile_cont(0.95, c1) WITHIN GROUP (ORDER BY c3) FROM aggregate_test_100 -statement error DataFusion error: Error during planning: Percentile value for 'APPROX_PERCENTILE_CONT' must be a literal +statement error DataFusion error: Error during planning: Percentile value for 'APPROX_PERCENTILE_CONT' must be constant across the aggregation, found differing values Review Comment: This project prefers to use sqllogictests, as those have greater stability guarantees across contributions, are easier to review, and easier to maintain (they update themselves on changes). If you see some overlap, then let's remove the unit tests and just have sqllogictests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
