comphead commented on PR #6698: URL: https://github.com/apache/datafusion-comet/pull/6698#issuecomment-6020042260
Thanks @andygrove, reworked in 16fb61d17c along these lines. `spark.comet.exec.allowedDataFusionConfigs` is gone. `spark.comet.exec.spill.compression.codec` accepts `lz4`, `zstd` and `none`, defaults to `lz4`, and is validated with `checkValues`. `serializeCometSQLConfs` sends the resolved value, and `prepare_datafusion_session_context` maps it to DataFusion's `SpillCompression` before the testing pass-through, so the `CometTaskMetricsSuite` tests that set `zstd` keep working. I went with a separate key for the reasons you gave. The new `CometExecSuite` test checks that a spilling native sort writes fewer `spilled_bytes` with the default than with `none`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
