andygrove commented on PR #6607: URL: https://github.com/apache/datafusion-comet/pull/6607#issuecomment-6021061724
I've updated the description. The stream read bullet now covers only the range sampling change, the overlap paragraph is gone, and the `CometExecRule` bullet credits the fallback case for transitions to #6564. It also mentions the revert's new INFO text. While I was there I changed "hash aggregates" to "aggregates" in the revert bullet to match the docs, dropped the stream read and the fallback case from the list of changes the tests catch, and updated the test counts at c90dcfca5. The `Lint Java (Spark 4.0, JDK 21)` failure wasn't from the merge. In its log, the download of `scala-compiler-2.13.16.jar` starts and never finishes, and `scala-compile-first` then fails on `comet-common` with `ClassNotFoundException: scala.tools.nsc.Main`, before any source is compiled. The JDK 17 job downloaded the same jar and passed, and on c90dcfca5 the JDK 21 job passed too. I've applied `run-all-spark-profiles`. The Comet suites on 3.4, 3.5, 4.0 and 4.2 are running now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
