NoahKusaba commented on code in PR #20:
URL: https://github.com/apache/datafusion-iceberg/pull/20#discussion_r4199394112
##########
crates/datafusion/src/physical_plan/scan.rs:
##########
@@ -91,8 +187,10 @@ impl IcebergTableScan {
self.snapshot_id
}
- pub fn projection(&self) -> Option<&[String]> {
- self.projection.as_deref()
+ /// The names of the columns the scan reads, which are the fields of its
+ /// schema.
+ pub fn projection(&self) -> &[String] {
Review Comment:
Thanks, done. The description now has a "user-facing changes" section that
calls `projection()` out as a breaking change against 0.10.1, and the stale
"keeps its signature" sentence is gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
