Prajwal-k-tech commented on PR #26042: URL: https://github.com/apache/datafusion/pull/26042#issuecomment-6023901874
Thanks for the detailed review. I pushed the follow-up to the existing fork branch in commits `16a78c3` and `63cc845`. - Outer-join pruning now replaces nullable-side columns with NULL structurally and retains equivalence groups whose rewritten expressions match, including expressions that produce the same non-NULL result. It does not evaluate physical expressions or ScalarUDFs during planning. - The synthetic `RecordBatch` is removed, avoiding its allocations, physical-null-buffer assumptions, and reconstructed fields that lost metadata. - The public `EquivalenceGroup::join` now applies the same conservative outer-join handling without requiring a schema; its docs describe that behavior. - Added coverage for RIGHT JOIN, a no-key inner-join path, and expressions with matching non-NULL results after null extension. Moved the stranded import. Validation: `cargo fmt --all -- --check`, workspace Clippy (`cargo clippy --all-targets --all-features -- -D warnings`), all 1,690 `datafusion-physical-expr` unit tests (1,688 passed, 2 ignored), and the focused `joins.slt` suite pass. The repository-wide extended tests could not complete because this checkout lacks `datafusion/testing/data`; a representative failure reports that `ARROW_TEST_DATA` is unset and asks for the test-data submodule. I have not counted that suite as passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
