Richard-Durkee opened a new pull request, #2556: URL: https://github.com/apache/datafusion-ballista/pull/2556
# Which issue does this PR close? No linked issue. # Rationale for this change `PrometheusMetricsCollector::new` registers its metrics on the registry you pass in, but `gather_metrics` always read the global default registry. With a custom registry, `/api/metrics` came back empty. # What changes are included in this PR? Store the registry on the collector and gather from it. Added a test that fails without the fix. # Are there any user-facing changes? No. The default collector uses the global registry, so `/api/metrics` output is unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
