tshauck commented on code in PR #12224:
URL: https://github.com/apache/datafusion/pull/12224#discussion_r1737113525
##########
datafusion/sqllogictest/test_files/string_view.slt:
##########
@@ -776,7 +776,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
-01)Projection: concat(CAST(test.column1_utf8view AS Utf8),
CAST(test.column2_utf8view AS Utf8)) AS c
+01)Projection: concat(test.column1_utf8view, test.column2_utf8view) AS c
Review Comment:
💪
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -46,7 +45,7 @@ impl ConcatFunc {
pub fn new() -> Self {
use DataType::*;
Self {
- signature: Signature::variadic(vec![Utf8], Volatility::Immutable),
+ signature: Signature::variadic(vec![Utf8, Utf8View],
Volatility::Immutable),
Review Comment:
Perhaps as a follow on PR we can expand this to also support `LargeUtf8`s...
though it looks like maybe they are from the tests? Does this just need to be
updated and it'll work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
