2010YOUY01 commented on PR #24697: URL: https://github.com/apache/datafusion/pull/24697#issuecomment-6033678465
Thank you, the structure inside AggregateExec LGTM. Though I might not be able to review this entire PR now. > One naming question: would you prefer to rename `GroupCompletionMode` to `GroupClusteringMode` to align with the clustering terminology you suggested? Yes, I agree `GroupClusteringMode` looks better, and I think it's also important to have a unified term for this family of optimization in the codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
