rexminnis commented on PR #2485: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2485#issuecomment-6034097518
Hi @LucaCappelletti94, could this get a committer review when you have a moment? All checks pass on the current head (`fd150b0`) and @edmondop approved it on Oct 1. It only adds a new dialect (`TrinoDialect`, registered as `"trino"`) through the existing dialect hooks, plus a test corpus in `tests/sqlparser_trino.rs`; existing dialects are unchanged. A note on #2486 (`FOR TIMESTAMP AS OF` / `FOR VERSION AS OF`): it's stacked on this PR. Its CI runs expired while waiting for workflow approval, so it hasn't been tested here yet. Once this one merges I'll rebase #2486 onto `main` so it shows only its own commit, and its CI can run then. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
