mohitgurav20 commented on PR #25719: URL: https://github.com/apache/datafusion/pull/25719#issuecomment-6037655401
@asolimando Thanks for pointing those out! I've addressed all the comments in the latest commits: Scalar Subquery FilterExec Test: Added test_filter_statistics_fallback_scalar_subquery_uses_ndv using StatisticsExec (1,000 rows, NDV = 200) with a = <ScalarSubqueryExpr>, asserting num_rows == Inexact(5) (1/NDV). CAST Test: Replaced the previous test with test_filter_statistics_fallback_cast_scalar_subquery_uses_default (CAST(a AS Int64) = <ScalarSubqueryExpr>), which confirms that wrapped columns fall back to the 20% default (num_rows == Inexact(200)). Also kept a direct unit test test_fallback_selectivity_cast_expr_not_handled. Removed SLT Tests: Removed the tests in subquery.slt since tables from VALUES don't populate column NDVs and end-to-end coverage is now handled in filter.rs. Cleaned up the comment references to describe only current behavior, and synced with main via a merge commit so the diff stays reviewable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
