martin-g commented on code in PR #25005:
URL: https://github.com/apache/datafusion/pull/25005#discussion_r4092662642
##########
datafusion/sql/src/statement.rs:
##########
@@ -1235,6 +1235,10 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
plan_err!("Delete-order-by clause not yet supported")?;
}
+ if limit.is_some() {
+ return not_impl_err!("Delete-limit clause not supported");
Review Comment:
I agree that `NotImplemented` would be the best but the other checks
above/below use PlanningError. IMO it would be better to be consistent.
```suggestion
return plan_err!("Delete-limit clause not yet
supported");
```
Update (Oct 7 2026): DELETE+LIMIT won't be implemented. See #24998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
