tshauck commented on code in PR #12212: URL: https://github.com/apache/datafusion/pull/12212#discussion_r1737166577
########## datafusion/sqllogictest/test_files/string_view.slt: ########## @@ -1225,6 +1221,48 @@ XiangpengXiangpeng XiangpengXiangpeng XiangpengXiangpeng RaphaelRaphael RaphaelRaphael RaphaelRaphael NULL NULL NULL +## Ensure no casts for binary operators +## TODO: https://github.com/apache/datafusion/issues/12180 +# `~` operator (regex match) +query TT +EXPLAIN SELECT Review Comment: Just parroting some feedback I got on a similar PR: might be nice to include the queries w/o `EXPLAIN` so as to verify correctness not just casts (or in the future no casts 😄). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
