asolimando commented on code in PR #26094:
URL: https://github.com/apache/datafusion/pull/26094#discussion_r4207373709
##########
datafusion/physical-optimizer/src/ensure_requirements/enforce_distribution.rs:
##########
@@ -1162,53 +1161,52 @@ fn enforce_distribution_relationships(
}
}
- let best_satisfied_child: Option<(usize, Partitioning)> = match
satisfied_children
- .len()
- {
- 0 => None,
- 1 => satisfied_children
- .into_iter()
- .next()
- .map(|(i, p, _)| (i, p)),
- _ => {
- // Prefer native partitioned children over newly repartitioned
ones
- let native_children: Vec<_> = satisfied_children
- .iter()
- .filter(|(_, _, is_native)| *is_native)
- .collect();
- if native_children.len() == 1 {
- let (i, p, _) = native_children[0];
- Some((*i, p.clone()))
- } else {
- let pool = if !native_children.is_empty() {
- native_children
- } else {
- satisfied_children.iter().collect()
- };
- let candidates: Vec<_> = pool
- .into_iter()
- .map(|(idx, part, _)| {
- let size =
-
PlanSize::from_plan(children[*idx].context.plan.as_ref());
- (size, *idx, part.clone())
- })
- .collect();
-
- // Prefer a unique, strictly larger winner (`size_a >
size_b`).
- // Otherwise, fall back to standard distribution rather
- // than choosing an arbitrary reference.
- candidates
+ let best_satisfied_child: Option<(usize, Partitioning)> =
Review Comment:
Note to reviewers: re-indented by `rustfmt`, the real change is passing
`stats_ctx` to `PlanSize::from_plan`, but the diff can be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
