sunchao opened a new issue, #6748:
URL: https://github.com/apache/datafusion-comet/issues/6748

   Follow-up to #6429 and the [Azure/GCS review 
comment](https://github.com/apache/datafusion-comet/pull/6429#discussion_r4196850573).
   
   The scan HTTP counters introduced in #6429 instrument only the native S3 
connector. Native Azure and GCS scans currently report zero HTTP coverage even 
when their clients retry requests.
   
   Extend the same per-request attribution to native Azure and GCS:
   
   - Install `ScanHttpConnector` on the `MicrosoftAzureBuilder` in 
`objectstore::azure::create_store`.
   - Provide an instrumented `GoogleCloudStorageBuilder` construction path in 
place of the current GCS `parse_url` route, preserving its URL, credential, and 
client-option behavior.
   - Keep scan ownership in `GetOptions::extensions` so shared clients, 
HTTP-status retries, and interrupted-body resumes remain attributed to the 
original scan.
   - Add loopback tests through each production store builder for retries, body 
resumes, retry exhaustion, and concurrent scan isolation, and update the user 
guide's coverage statement.
   
   The pinned object_store 0.13.2 Azure and GCS builders both support 
`with_http_connector`, and their GET implementations forward the extensions 
through `with_get_options`. No retry-policy change is intended.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to