sunchao commented on PR #6429: URL: https://github.com/apache/datafusion-comet/pull/6429#issuecomment-6041739742
Pushed fa501d8fc and replied to all five review threads. The revision keeps observed GETs and retries, deriving total attempts from their sum. It replaces the standalone accumulator test with real-scan assertions, adds the 403 location re-route regression, clarifies backend coverage, and updates the accumulator benchmark. Azure/GCS coverage is tracked in #6748. Validation: 234 native core Parquet tests passed (one existing ignored benchmark), including all five HTTP tests. The real scan regression passed on Spark 4.0.4/JDK 17. Spotless, Scala style, changed-file Rust formatting, Markdown formatting, and whitespace checks passed. Local Spark 4.1 validation remains blocked by the configured Maven mirror's DNS failure for `jackson-bom:2.21.2`. [Benchmark results](https://github.com/apache/datafusion-comet/pull/6429#discussion_r4209093194) are posted inline and in the PR description. The two added accumulators measured 3.6–7.0 µs/task over the original nine in forward/reverse runs. Native HTTP instrumentation overhead remains unmeasured. CI for the new commit is running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
