andygrove commented on code in PR #6740:
URL: https://github.com/apache/datafusion-comet/pull/6740#discussion_r4209159878
##########
native/proto/src/proto/expr.proto:
##########
@@ -597,6 +597,11 @@ message TruncTimestamp {
Expr format = 1;
Expr child = 2;
string timezone = 3;
+ // Whether SECOND and MILLISECOND truncation wraps when the result would
fall below the
+ // smallest timestamp. Spark before 4.2.0 wraps the Long subtraction; 4.2.0
(SPARK-56663)
+ // raises `long overflow` like every other unit. This tracks the Spark
version Comet is
+ // running against.
+ bool wrap_second_millisecond_overflow = 4;
Review Comment:
I think it is better to name the behavior rather than a Spark version. Some
companies maintain forks of Spark and backport fixes from newer OSS Spark
versions. These companies can leverate the shim layer to say which of their
versions have specific behavior. I have also seen in the past (although rarely)
that there are functional differences between different minor releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
