andygrove commented on issue #6757: URL: https://github.com/apache/datafusion-comet/issues/6757#issuecomment-6048374458
#6730 no longer reuses the views (0623dbac51). `MapWriter.writeArrayElements` now calls `writeEntries(array.getMap(i))`, so the `writeUnsafe` helper above is gone, but the quirk is still there. In the same harness, now warming 22 cases together, `array<map<string,int>>` takes 143 ns per row, and 108 with `-XX:CompileCommand=dontinline,...MapWriter::writeEntries` (two runs each). `main` takes 202 on it, so it is still faster than `main`, but about 1.3x slower than it could be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
