moshap-firebolt commented on PR #2614: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2614#issuecomment-6049645683
> You could gate unqualified intervals on string literals through a dialect capability, retaining qualifiers for numeric literals and excluding identifiers from literal values. > > Setting `require_interval_qualifier()` to `false` makes both dialects accept `SELECT INTERVAL 1`, which Spark 4.0.1 rejects, and misparse `SELECT interval FROM t` into `SELECT INTERVAL FROM AS t`, losing the table reference. Right, so kept `require_interval_qualifier` on `true` and added `supports_interval_string_without_qualifier` enabled for Spark/Databricks; also unreserved INTERVAL for both dialects similar to PG > I added some red tests to help out. Thanks - that was super helpful :pray: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
