rgbuilds commented on PR #25530: URL: https://github.com/apache/datafusion/pull/25530#issuecomment-6052359854
> @rgbuilds, > > Thanks for adding this regression coverage. The new tests verify the cross-join row metrics across different input batch layouts and address the issue requirements. I have one optional suggestion to make the multi-batch setup even more explicit. Thanks @kosiew for the review and suggestion! I’ve added assertions for both batch metrics to ensure the test continues to cover the intended multi-batch scenarios. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
