wudidapaopao commented on PR #25849: URL: https://github.com/apache/datafusion/pull/25849#issuecomment-6055826451
@neilconway Thanks, I agree that storing the literal array alongside its aggregate argument is cleaner and more natural. I’ve updated the PR accordingly and added literal `COUNT(1)` cases to the existing aggregate_filter Criterion benchmark. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
