lewiszlw opened a new issue, #12255:
URL: https://github.com/apache/datafusion/issues/12255

   I have always thought that making `LexRequirement` an actual struct with 
methods and documentation would be even better
   
   For example,  something like
   
   ```rust
   /// Describes a lexical (multi-column) sort requirement
   struct LexRequirement {
     inner: Vec<PhysicalSortRequirement>>
   }
   
   impl LexRequirement { 
   // documented methods here
   ...
   }
   
   ```
   
   Otherwise the rust docs just show as `Vec<PhysicalSortRequirement>` and it 
is unclear what operations are used
   
   _Originally posted by @alamb in 
https://github.com/apache/datafusion/pull/12130#pullrequestreview-2257616876_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to