goingforstudying-ctrl commented on code in PR #2562:
URL:
https://github.com/apache/datafusion-ballista/pull/2562#discussion_r4223860749
##########
ballista/executor/src/runtime_cache.rs:
##########
@@ -138,10 +153,41 @@ impl SessionRuntimeCache for DefaultSessionRuntimeCache {
}
}
+/// Fingerprint of the session config's extension entries.
+///
+/// A base [`RuntimeEnv`] bakes in whatever config the producer reads at build
+/// time (e.g. the `S3Options` cloned into the object-store registry), and
+/// every extension entry flows through `SET`-driven task properties, so this
+/// is the part of the config that can legitimately change mid-session.
+/// Built-in `datafusion.*` options are not included: they do not feed the
+/// base env's shared state.
+///
+/// Extension iteration is ordered by prefix, and each extension's entries
+/// are sorted by key, so equal configs always produce equal fingerprints.
+fn config_fingerprint(config: &SessionConfig) -> u64 {
+ let mut hasher = DefaultHasher::new();
+ for (prefix, extension) in config.options().extensions.iter() {
Review Comment:
Done in 1ddb6bc. `config_fingerprint` now skips `BallistaConfig::PREFIX`, so
`SET ballista.job.name` no longer busts the cached base.
`changed_ballista_job_name_hits_same_base_runtime` is the test you
suggested: both job names produce the same `Arc` base, with a check the SET
actually landed. Also added `fingerprint_ignores_ballista_extension` to pin
that an `s3.*` change still rekeys while a job-name change does not. Suite
passes, clippy and fmt clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
