github-actions[bot] commented on PR #26155: URL: https://github.com/apache/datafusion/pull/26155#issuecomment-6079303473
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.1.0 (current) Built [ 54.660s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.031s] (current) Building datafusion v55.1.0 (baseline) Built [ 53.914s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.636s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 110.930s] datafusion Building datafusion-common v55.1.0 (current) Built [ 32.723s] (current) Parsing datafusion-common v55.1.0 (current) Parsed [ 0.063s] (current) Building datafusion-common v55.1.0 (baseline) Built [ 32.489s] (baseline) Parsing datafusion-common v55.1.0 (baseline) Parsed [ 0.064s] (baseline) Checking datafusion-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.765s] 223 checks: 220 pass, 3 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field TableOptions.arrow in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:2971 --- failure enum_unit_variant_changed_kind: An enum unit variant changed kind --- Description: A public enum's exhaustive unit variant has changed to a different kind of enum variant, breaking possible instantiations and patterns. ref: https://doc.rust-lang.org/reference/items/enumerations.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_unit_variant_changed_kind.ron Failed in: variant OutputFormat::ARROW in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:4225 --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant ConfigFileType:ARROW in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:2950 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 67.184s] datafusion-common Building datafusion-datasource-arrow v55.1.0 (current) Built [ 40.355s] (current) Parsing datafusion-datasource-arrow v55.1.0 (current) Parsed [ 0.007s] (current) Building datafusion-datasource-arrow v55.1.0 (baseline) Built [ 40.783s] (baseline) Parsing datafusion-datasource-arrow v55.1.0 (baseline) Parsed [ 0.007s] (baseline) Checking datafusion-datasource-arrow v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.077s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure unit_struct_changed_kind: unit struct changed kind --- Description: A public unit struct has been changed to a normal (curly-braces) struct, which cannot be constructed using the same struct literal syntax. ref: https://github.com/rust-lang/cargo/pull/10871 impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/unit_struct_changed_kind.ron Failed in: struct ArrowFormat in /home/runner/work/datafusion/datafusion/datafusion/datasource-arrow/src/file_format.rs:138 struct ArrowFormat in /home/runner/work/datafusion/datafusion/datafusion/datasource-arrow/src/file_format.rs:138 struct ArrowFormatFactory in /home/runner/work/datafusion/datafusion/datafusion/datasource-arrow/src/file_format.rs:80 struct ArrowFormatFactory in /home/runner/work/datafusion/datafusion/datafusion/datasource-arrow/src/file_format.rs:80 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 82.290s] datafusion-datasource-arrow Building datafusion-ffi v55.1.0 (current) Built [ 53.370s] (current) Parsing datafusion-ffi v55.1.0 (current) Parsed [ 0.060s] (current) Building datafusion-ffi v55.1.0 (baseline) Built [ 52.804s] (baseline) Parsing datafusion-ffi v55.1.0 (baseline) Parsed [ 0.059s] (baseline) Checking datafusion-ffi v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.265s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 107.927s] datafusion-ffi Building datafusion-proto v55.1.0 (current) Built [ 49.498s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.012s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 49.376s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.128s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 100.313s] datafusion-proto Building datafusion-sqllogictest v55.1.0 (current) Built [ 92.441s] (current) Parsing datafusion-sqllogictest v55.1.0 (current) Parsed [ 0.015s] (current) Building datafusion-sqllogictest v55.1.0 (baseline) Built [ 92.607s] (baseline) Parsing datafusion-sqllogictest v55.1.0 (baseline) Parsed [ 0.016s] (baseline) Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.110s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 187.531s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
