osipovartem commented on PR #26145: URL: https://github.com/apache/datafusion/pull/26145#issuecomment-6087861930
I checked the latest Codecov `compare/file` report (head `c9dbd63`) line by line. The 74.09% patch figure includes test-only code and partial coverage for the error branch of `?` in otherwise exercised tests. In the new CASE metadata runtime helper, the four fully missed lines are defensive `internal_err!` branches for an inconsistent internal work stack; the ordinary, conflicting-metadata, nested, cast/alias, scalar-UDF, higher-order-UDF, and depth-limited paths have direct tests. I do not think manufacturing malformed internal state solely to raise the patch percentage would improve the contract coverage. The PR remains draft for the separate follow-up work described above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
