comphead commented on code in PR #6754:
URL: https://github.com/apache/datafusion-comet/pull/6754#discussion_r4231745377
##########
spark/src/test/scala/org/apache/comet/CometIcebergNativeSuite.scala:
##########
@@ -166,6 +166,42 @@ class CometIcebergNativeSuite
}
}
+ // https://github.com/apache/datafusion-comet/issues/6707
+ test("input_file_name and input_file_block_* fall back to Spark's Iceberg
reader") {
Review Comment:
Since it only runs SQL, could this live in a fixture under
`sql-tests/iceberg/` instead? `query expect_fallback(<reason>)` calls the same
`checkSparkAnswerAndFallbackReason` (`CometSqlFileTestSuite.scala:205`), and a
plain `query` for the native control checks every operator, as
`metadata_column_partition.sql` already does for filtered reads. That file's
`MaxSparkVersion` and `test_cat` catalog lines and its `DROP TABLE IF EXISTS`
setup can be copied, since the auto-cleanup does not drop `test_cat.db.*`
tables. I would match the full `Native V2 scan is not compatible with
input_file_name` there, because `input_file_name` alone also matches
`input_file_name is not supported`, which the projection records when the scan
stays native. I have not run any of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
