mightsleep commented on PR #26159: URL: https://github.com/apache/datafusion/pull/26159#issuecomment-6089118149
yes hello, the slim version keeps the no-nulls gain, but it also drops the null-key one. On x86 (Zen 5) I measured main + get_unchecked at 1.01x / 0.99x on "single, nulls" / "multiple, nulls". With your 64-bit mask walk kept only for mixed chunks (full chunks and the no-nulls case use the same plain get_unchecked loop), it was 3.0x / 2.4x, without the manual unroll alamb wanted gone. Might be worth bringing that part back, with the chunk test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
