andygrove commented on PR #4672: URL: https://github.com/apache/datafusion-comet/pull/4672#issuecomment-6085984826
@sandugood thanks for all the work on this. It's been quiet for a few weeks, so I've picked it up in #6824 to get it over the line. I kept your commits on that branch, so you'll be credited as co-author when it merges. On top of your changes, it merges main, since #6604 reworked the same macro. It also takes the bitmap path only for arrays of 64 or more elements. Building the validity and value buffers costs four allocations per array, which made shorter arrays with nulls slower than the per-element loop (sunchao's review above has the details). Your review on #6824 would be very welcome. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
